EXT_lights_area #2525
Open
EXT_lights_area #2525
+255
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexaknyazev
reviewed
Sep 12, 2025
Comment on lines
87
to
89
| | `width` | `number` | Width of the rectangular light in meters. Must be a positive value. Required for `rect` lights, ignored for `disk` lights. | Conditional | `1.0` | | ||
| | `height` | `number` | Height of the rectangular light in meters. Must be a positive value. Required for `rect` lights, ignored for `disk` lights. | Conditional | `1.0` | | ||
| | `radius` | `number` | Radius of the disk light in meters. Must be a positive value. Required for `disk` lights, ignored for `rect` lights. | Conditional | `1.0` | |
Member
There was a problem hiding this comment.
For consistency, it might be better to follow the punctual lights schema with shape-specific properties located in nested objects.
Alternatively:
- There might be a common property, e.g.,
size. The rectangular shape may then have arect.aspectRatioproperty while thediskshape wouldn't need anything else. - All these properties could be assumed as always being 1.0 and the actual size would always be controlled by node transforms.
Contributor
Author
There was a problem hiding this comment.
Great call. I'll make that change.
extensions/2.0/Vendor/EXT_lights_area/schema/light.area.schema.json
Outdated
Show resolved
Hide resolved
extensions/2.0/Vendor/EXT_lights_area/schema/light.area.schema.json
Outdated
Show resolved
Hide resolved
sebavan
pushed a commit
to BabylonJS/Babylon.js
that referenced
this pull request
Sep 15, 2025
Added importing support for first version of EXT_light_area extension. KhronosGroup/glTF#2525
bghgary
reviewed
Sep 18, 2025
Contributor
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
Small comments. Do we need to discuss whether this extension should be EXT or KHR?
|
|
||
| Written against the glTF 2.0 spec. | ||
|
|
||
| ## Overview |
Contributor
There was a problem hiding this comment.
Would it help to add a couple of pictures with an example of a rect and a disk in the real world for illustration purposes?
Co-authored-by: Gary Hsu <[email protected]>
Co-authored-by: Gary Hsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost identical to the previously-proposed KHR area lights extension except that it excludes "sphere" as a valid shape in favour of only flat lights. (See #1948).