Added reset & fix memory leak when unmount parent#9
Open
alesanderlopez wants to merge 3 commits intoKerumen:masterfrom
Open
Added reset & fix memory leak when unmount parent#9alesanderlopez wants to merge 3 commits intoKerumen:masterfrom
alesanderlopez wants to merge 3 commits intoKerumen:masterfrom
Conversation
- added method: [reset] to reset the counter again to start. - added method: [componentWillUnmount] to stop the counter and fix memory leak when Unmount parent view or change view in react-native-router-flux - update method: [animate] for stop the loop when the componentWillUnmount was executed
ywongweb
pushed a commit
to ywongweb/react-native-counter
that referenced
this pull request
Sep 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counter.js
Readme.md