Repository navigation
Fixing a perf-related issue - #467
Open
patrikcerbak wants to merge 2 commits into
Open
patrikcerbak wants to merge 2 commits into
patrikcerbak wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes a perf issue mentioned here:
#465 (comment)
I fixed that by specifying which PMU events should be collected by perf (using
perf stat -e ...) and not relying on the default selection, as it is not supported on GHA ARM machines. The selected events/metrics are a subset that works on both AMD and ARM GHA machines.I checked the output of the affected tests and some metrics are still not collected (for example
branchMisses,branches,cycles, etc. still have the-1value), but those were also not collected before these changes. The number of collected metrics stays the same.