Modplug update#169
Open
QuzarDC wants to merge 2 commits into
Open
Conversation
added 2 commits
July 11, 2026 18:08
When paired with `DISTFILE_DIR` or cmake's outsource copy using the relative paths would look in the wrong place for inst folder.
We were hosting our own copy of an ancient version for no good reason. Migrating this way will allow for the archival of the `KallistiOS/libmodplug` repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First a fix to the build script for the installation process. Trying to specify a subfolder of the git repo to build from tripped over this bug.
Then migrate the libmodplug port to pull from the official repo. Our hosted one had no specialized KOS code in it, it was just whatever version was pulled down 20 years ago and we never got around to dumping it.
modplug example builds, but needs some testing to be sure there aren't any updates needed for expected function.
EDIT: example also works just fine with this mainline modplug. Updated it so it cleans up after itself better.