Open
Conversation
Contributor
|
I think we should merge the py3 branch into master first, an then add this branch |
Contributor
|
This PR needs to be updated for py3 and black |
Contributor
|
are these changes still required ? |
Author
|
Sorry for the late response, I used the old version of Dumbledraw for tau ID+es corrections, I think these changes might provoke some conflicts. I can check if it's a case and then we can merge them. Does this solution work? |
Contributor
|
yes, since this branch is now more then 2 years old, you may want to start from the main branch again and just cherry-pick this commit: 4a67718 to see if this already covers all your required changes |
harrypuuter
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tau energy scale adaptations