General fixes for Run 2 and 3 analyses#363
Open
sofiagiappichini wants to merge 9 commits intomainfrom
Open
Conversation
moritzmolch
reviewed
Feb 11, 2026
Contributor
moritzmolch
left a comment
moritzmolch
left a comment
There was a problem hiding this comment.
Some functions let the unittest config fail because of changes in some function signatures. Otherwise, the changes look fine to me.
| const std::string &variation_dm1_pt20to40, const std::string &variation_dm1_pt40toInf, | ||
| const std::string &variation_dm10_pt20to40, const std::string &variation_dm10_pt40toInf, | ||
| const std::string &variation_dm11_pt20to40, const std::string &variation_dm11_pt40toInf); | ||
| ROOT::RDF::RNode Id_vsEle( |
Contributor
There was a problem hiding this comment.
The unittest config needs to be modified here, so that it includes the era parameter in the function call. Otherwise, the build_project step of the GitHub workflow is failing, e.g., https://github.com/KIT-CMS/CROWN/actions/runs/21877079764/job/63148873701?pr=363.
| const std::string &genpair); | ||
| const std::string &genindex_particle2); | ||
| ROOT::RDF::RNode | ||
| buildtruegenpair(ROOT::RDF::RNode df, const std::string &statusflags, |
Contributor
There was a problem hiding this comment.
I guess, that the unittest config will also fail here because of the modified function signature.
| * @param genpairname name of the new column containing the GenDiTauPair | ||
| * @return a new Dataframe with the GenDiTauPair column | ||
| */ | ||
| ROOT::RDF::RNode buildgenpair(ROOT::RDF::RNode df, const std::string &recopair, |
Contributor
There was a problem hiding this comment.
I guess, that the unittest config will also fail here because of the modified function signature.
…T after the corrections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the remaining producers with input before the output, a new combined producer for vs electron ID scale factors with a dependence on the era since the inputs for the JSON vary, and a fix of out of bound indeces access for Recoil corrections for Run2.