Skip to content

Update to tau SF producer and jet pt corrections for 2024 samples#353

Open
sofiagiappichini wants to merge 15 commits intomainfrom
corrections_2024
Open

Update to tau SF producer and jet pt corrections for 2024 samples#353
sofiagiappichini wants to merge 15 commits intomainfrom
corrections_2024

Conversation

@sofiagiappichini
Copy link
Contributor

With the 2024 tau SF correction a new dependency on the electron working-point is introduced in the evaluation of the vs. muon tau ID. The ID_vsMu producer is then extended to add the electron working-point, as well as an era parameter to control the dependency.

The jet MC and data pt correction producers have been streamlined to use the same era parameter, instead of an additional LHC run parameter to distinguish between Run 2 and 3. Additionally, the energy scale SF corrections in Run 3 take additional parameters based on the individual era. The producers are extended to cover all cases based on the era analysed.

A new producer is introduced to create a mask with a minimum cut on an event variable with type template.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates tau scale factor (SF) producers and jet pt correction producers to handle 2024 CMS data samples with new dependencies and era-based corrections.

Changes:

  • Extended tau ID_vsMu producer to include electron and jet working-point parameters required for 2024/2025 tau SF corrections
  • Refactored jet MC and data pt correction producers to use era strings instead of LHC run numbers, with support for Run 3 era-specific parameters
  • Added new CutMinSingle template function for creating event-level variable masks with minimum threshold cuts

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/taus.cxx Added era, electron WP, and jet WP parameters to tau vsMu ID SF producer with conditional evaluation logic
src/jets.cxx Replaced LHC run parameter with era string in jet pt correction producers and added era-specific parameter handling
src/electrons.cxx Moved debug logging statements inside lambda function
include/taus.hxx Updated function signature to include new era and working-point parameters
include/physicsobjects.hxx Added new CutMinSingle template function for single-value threshold masking
include/jets.hxx Updated function signatures with new era and run parameters
data/jsonpog-integration Updated subproject commit reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@KIT-CMS KIT-CMS deleted a comment from Copilot AI Jan 15, 2026
@KIT-CMS KIT-CMS deleted a comment from Copilot AI Jan 15, 2026
@KIT-CMS KIT-CMS deleted a comment from Copilot AI Jan 15, 2026
Copy link
Contributor

@nshadskiy nshadskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks. I would merge it after it is propagated to the analyses repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants