Update to tau SF producer and jet pt corrections for 2024 samples#353
Open
sofiagiappichini wants to merge 15 commits intomainfrom
Open
Update to tau SF producer and jet pt corrections for 2024 samples#353sofiagiappichini wants to merge 15 commits intomainfrom
sofiagiappichini wants to merge 15 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates tau scale factor (SF) producers and jet pt correction producers to handle 2024 CMS data samples with new dependencies and era-based corrections.
Changes:
- Extended tau
ID_vsMuproducer to include electron and jet working-point parameters required for 2024/2025 tau SF corrections - Refactored jet MC and data pt correction producers to use era strings instead of LHC run numbers, with support for Run 3 era-specific parameters
- Added new
CutMinSingletemplate function for creating event-level variable masks with minimum threshold cuts
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/taus.cxx | Added era, electron WP, and jet WP parameters to tau vsMu ID SF producer with conditional evaluation logic |
| src/jets.cxx | Replaced LHC run parameter with era string in jet pt correction producers and added era-specific parameter handling |
| src/electrons.cxx | Moved debug logging statements inside lambda function |
| include/taus.hxx | Updated function signature to include new era and working-point parameters |
| include/physicsobjects.hxx | Added new CutMinSingle template function for single-value threshold masking |
| include/jets.hxx | Updated function signatures with new era and run parameters |
| data/jsonpog-integration | Updated subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nshadskiy
approved these changes
Jan 16, 2026
Contributor
nshadskiy
left a comment
There was a problem hiding this comment.
Works for me, thanks. I would merge it after it is propagated to the analyses repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the 2024 tau SF correction a new dependency on the electron working-point is introduced in the evaluation of the vs. muon tau ID. The
ID_vsMuproducer is then extended to add the electron working-point, as well as an era parameter to control the dependency.The jet MC and data pt correction producers have been streamlined to use the same era parameter, instead of an additional LHC run parameter to distinguish between Run 2 and 3. Additionally, the energy scale SF corrections in Run 3 take additional parameters based on the individual era. The producers are extended to cover all cases based on the era analysed.
A new producer is introduced to create a mask with a minimum cut on an event variable with type template.