fixes #59 #60
Open
fixes #59 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issam-b
reviewed
Aug 11, 2024
| @@ -2,7 +2,8 @@ | |||
| CONFIG(release, debug|release): SSL_PATH = $$PWD | |||
| else: SSL_PATH = $$PWD/no-asm | |||
|
|
|||
| if (versionAtLeast(QT_VERSION, 6.5.0)) { | |||
| if (versionAtLeast(QT_VERSION, 6.5.0) | if(versionAtLeast(QT_VERSION, 5.15.8) : versionAtMost(QT_VERSION, 6.0.0))) { | |||
| message(Using OpenSSL v3) | |||
There was a problem hiding this comment.
these prints are done only for qmake, either add to cmake also or remove them to keep things more consistent
Issam-b
requested changes
Aug 11, 2024
I missed this thread due to a busy inbox, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59, about using OpenSSL 3 for Qt 5.15.8+ LTS.
The required patch can be found in https://gist.github.com/seyedmmousavi/b1f6681eb37f3edbe3dcabb6e89c5d43