Repository navigation
Win make - #61
Open
KarlKeiser wants to merge 9 commits into
Open
Win make#61KarlKeiser wants to merge 9 commits into
KarlKeiser wants to merge 9 commits into
Conversation
c-bik
requested changes
Aug 21, 2018
c-bik
left a comment
c-bik
left a comment
Member
There was a problem hiding this comment.
Thanks 👍.
Looks great. We are almost there!
This review has a few questions and improvement suggestions for your consideration.
| /LIBPATH:"$(WIN_SDK_ROOT)\um\x64"\ | ||
| /LIBPATH:"$(WIN_SDK_ROOT)\ucrt\x64"\ | ||
| /LIBPATH:"%ERL_INTERFACE_DIR%\lib"\ | ||
| /LIBPATH:"%ERL_INTERFACE_DIR%\include" |
Member
There was a problem hiding this comment.
Fix indent.
four spaces, instead of a TAB everywhere
|
|
||
|
|
||
| erloci.exe: erloci.lib priv\transcoder.obj priv\threads.obj priv\term.obj priv\port.obj priv\marshal.obj priv\logger.obj priv\erloci.obj priv\cmd_queue.obj priv\command.obj priv\erloci.obj | ||
| $(LINK) $(LINKFLAGS) /OUT:"priv\ocierl.exe" priv\transcoder.obj priv\threads.obj priv\term.obj priv\port.obj priv\marshal.obj priv\logger.obj priv\erloci.obj priv\cmd_queue.obj priv\command.obj priv\erloci.lib |
Member
There was a problem hiding this comment.
Can we use some kind wildcard (like priv\*.obj) to select all .obj files?
Listing them isn't quite readable or maintainable!
| # initialization done at the beginning of the installation | ||
| init: # | ||
| -@ if NOT EXIST "priv" mkdir "priv" | ||
|
|
|
|
||
| # version of the Win SDK usually found in C:\Program Files (x86)\Windows Kits\10\Lib\ | ||
| WIN_SDK_VERSION = 10.0.17134.0 | ||
| # -------------------------- |
Member
There was a problem hiding this comment.
Is there a way to autodetect these versions (or the path) instead of hardcoding them?
| MSBuild c_src/erlocisln.sln /t:Clean /p:Configuration=$(conf) /p:Platform="x64" /m | ||
| del priv\*.lib priv\*.dll priv\*.exe /f /q | ||
| @echo Clean $(conf) | ||
| CPP = "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.15.26726\bin\Hostx64\x64\cl.exe" |
Member
There was a problem hiding this comment.
Can it be autodetectable instead of hardcoding?
added 2 commits
August 24, 2018 08:26
fix some path/library dependencies, remove hardcoded version numbers
c-bik
requested changes
Aug 31, 2018
c-bik
left a comment
c-bik
left a comment
Member
There was a problem hiding this comment.
Some cosmetics
- line break at 80 characters
- indent with 4 spaces
added 2 commits
September 6, 2018 14:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cleaned up the script and removed some redundancies. near the top of the script, there are two macros to set the version numbers of two paths. Maybe there is a possibility to automatically find those version numbers (as those subdirectories are the only ones in their respective directory), but I'll have too look into it some more.