Skip to content

Strip out the V1 UI detritus - #308

Merged
davertay-j merged 4 commits into
mainfrom
dt/dce_v2ui
Aug 11, 2026
Merged

Strip out the V1 UI detritus#308
davertay-j merged 4 commits into
mainfrom
dt/dce_v2ui

Conversation

@davertay-j

@davertay-j davertay-j commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Replace the V1 views with V2 views. The diff is kind of messy looking but these were mostly a git mv operation.

Preserved the V1 settings that were never carried over as a new DebugSettings view enabled in debug builds only.


Note

Medium Risk
Large UI surface-area swap across browser chrome, settings, and permissions; release builds lose in-settings navigation to recent downloads unless another path exists, and search no longer exposes stop or security info affordances.

Overview
Removes the parallel *V2 SwiftUI stack and makes the V2 layouts the only NavBarView, SearchBarView, NavIconStrip, SettingsView, and PermissionsView. FreshPageView and WebContainerView now reference those canonical types instead of NavBarViewV2 / SettingsViewV2.

Navigation chrome switches from the old topaz bar with inline URL field and load progress to search-mode toggling: the icon strip opens an expanded search field with a dismiss control, updated tokens (cellFillPrimary, iconDefault), and embedInNavigationBackground. The magnifying-glass action replaces the old tab shortcut on the strip; fullscreen and settings stay on the strip.

Search is simplified: placeholder becomes “Search”, styling matches the new bar, trailing actions use clear/reload while editing vs idle (v1 stop-loading and security info sheet are removed from the view and model). Settings is no longer a navigation List; it is a dismissable modal card with Tabs, Share, clear website data, and Bluetooth permissions, with shared settingsButton helpers extracted to SettingsButton.swift. V1-only items (recent downloads, clear history, search engine picker) move to DebugSettings behind #if DEBUG. Bluetooth permissions uses the V2 custom header and sheet presentation instead of PermissionsViewV2 / navigation destinations.

Reviewed by Cursor Bugbot for commit 71e9875. Configure here.

@davertay-j davertay-j added the minor Changes that should bump the MINOR version number label Jul 22, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 71e9875. Configure here.

Comment thread lib/Sources/Settings/SettingsView.swift
@davertay-j
davertay-j requested review from Phoenix7351 and twyatt July 22, 2026 23:09
@davertay-j
davertay-j merged commit 61a86b4 into main Aug 11, 2026
4 checks passed
@davertay-j
davertay-j deleted the dt/dce_v2ui branch August 11, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Changes that should bump the MINOR version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants