Strip out the V1 UI detritus - #308
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 71e9875. Configure here.
twyatt
approved these changes
Jul 23, 2026
Phoenix7351
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replace the V1 views with V2 views. The diff is kind of messy looking but these were mostly a
git mvoperation.Preserved the V1 settings that were never carried over as a new
DebugSettingsview enabled in debug builds only.Note
Medium Risk
Large UI surface-area swap across browser chrome, settings, and permissions; release builds lose in-settings navigation to recent downloads unless another path exists, and search no longer exposes stop or security info affordances.
Overview
Removes the parallel
*V2SwiftUI stack and makes the V2 layouts the onlyNavBarView,SearchBarView,NavIconStrip,SettingsView, andPermissionsView.FreshPageViewandWebContainerViewnow reference those canonical types instead ofNavBarViewV2/SettingsViewV2.Navigation chrome switches from the old topaz bar with inline URL field and load progress to search-mode toggling: the icon strip opens an expanded search field with a dismiss control, updated tokens (
cellFillPrimary,iconDefault), andembedInNavigationBackground. The magnifying-glass action replaces the old tab shortcut on the strip; fullscreen and settings stay on the strip.Search is simplified: placeholder becomes “Search”, styling matches the new bar, trailing actions use clear/reload while editing vs idle (v1 stop-loading and security info sheet are removed from the view and model). Settings is no longer a navigation
List; it is a dismissable modal card with Tabs, Share, clear website data, and Bluetooth permissions, with sharedsettingsButtonhelpers extracted toSettingsButton.swift. V1-only items (recent downloads, clear history, search engine picker) move toDebugSettingsbehind#if DEBUG. Bluetooth permissions uses the V2 custom header and sheet presentation instead ofPermissionsViewV2/ navigation destinations.Reviewed by Cursor Bugbot for commit 71e9875. Configure here.