-
-
Notifications
You must be signed in to change notification settings - Fork 261
Addition, fixes, and improvements on layouts #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There is a phonetic layout which is used in old typewriters
Added ЯВЕРТЫ layout
Typo fixed
srcs/layouts/cyrl_jcuken_ru.xml
Outdated
| @@ -1,42 +1,42 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <keyboard name="ЙЦУКЕН (Русский)" script="cyrillic"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carrot-cookie and @Thunder-Squirrel, you edited this layout in the past, what do you think of these changes ?
srcs/layouts/cyrl_jiuken.xml
Outdated
| @@ -0,0 +1,44 @@ | |||
| <?xml version="1.0" encoding="utc-8"?> | |||
| <keyboard name="ЙІУКЕН" script="cyrillic"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typewriter in the picture has 11 columns while the layout you propose has 13. It seems that your layout has more letters on it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was one missing key on this layout, it's added later. Now it has the same amount of keys as on this picture. Both have 34 keys now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be like in the picture, з and х should be one row up, after щ. ц and э should be elsewhere entirely, perhaps in the corners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the bottom row is getting larger, making the keys even smaller. I suggest moving some keys, perhaps putting Shift on the second row ?
Co-authored-by: Jules Aguillon <[email protected]>
Letter б was missed, adding.
Julow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some warnings generated by the script:
armn_cpbsmo: Duplicate keys: չ
armn_cpbsmo: Layout includes some ASCII punctuation but not all, missing: !, ", #, $, %, &, ', *, +, <, =, >, ?, @, [, ], ^, `, {, }, ~
armn_kvertc: Layout includes some ASCII punctuation but not all, missing: !, ", #, $, %, &, ', *, +, <, =, >, ?, @, [, ], ^, `, {, }, ~
cyrl_jcuken_ru: Layout includes some ASCII punctuation but not all, missing: #, $, &, ', *, <, >, @, [, ], ^, `, {, }, ~
cyrl_jiuken: Layout includes some ASCII punctuation but not all, missing: #, $, &, ', *, +, <, =, >, @, [, ], ^, _, `, {, }, ~
cyrl_yaverti: Layout includes some ASCII punctuation but not all, missing: ~
cyrl_yawerty: Layout includes some ASCII punctuation but not all, missing: #, $, &, ', *, <, >, @, [, ], ^, `, {, }, ~
I guess the lack of ASCII punctuations is on purpose ? In that case only the warnings in armn_cpbsmo and cyrl_yaverti make sense.
|
@rafasaurus You added the previous Armenian layout in #490 |
|
let me build and test, will follow up |
Yes. These symbols appearing only on English and other Latin layouts. So not very great idea to overload Russian and Armenian layouts with these symbols. The symbols appeared are the most identical to what was using on actual layouts, as English one has f.e.. |
|
I would like to merge this but because you do a lot of things in the same PR, it's hard to review and discuss with other users. |
What is hard to review? Every change is explainable, just need to purify. |
Other contributors might want to have a look at your modifications to the existing layouts but it's not easy because your PR also add several layouts. I suggest that you open a new PR with the added layouts only, so that it can be merged quickly. |
You mean the removed/edited layouts would be here? |
Yes. |
So a branch for added keyboards was created, so there would be all added layouts, and edited/removed ones would be here. |

Armenian and Cyrillic layouts were changed by following way.
Note: Armenian symbols on Unicode (also formerly on ArmSCII) as "․" (U+2024) and "։" (U+0589) are different from normal "." (U+002E) and ":" (U+003A). Thus the last two were also added on lower section, to make proper experience as navigation on Armenian language domains.
If needed, addition of another layouts are possible, such as Dvorak-style.