-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for Sixel (take 2) #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Awesome work. I have invited you to the JuliaTesting org. Follow all the good practices, try and make sure you don't commit code without at least 1 person other than the author having looked at it, etc. |
Co-authored-by: Frames White <[email protected]>
|
Awesome. Thanks! |
| backends to be installed. | ||
| Proper image formats such as `.png` are also supported for full-res image testing. If your terminal | ||
| [supports Sixel](https://www.arewesixelyet.com/), then ReferenceTests will display the full image | ||
| in your terminal using (Sixel.jl)[https://github.com/JuliaIO/Sixel.jl]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| in your terminal using (Sixel.jl)[https://github.com/JuliaIO/Sixel.jl]: | |
| in your terminal using [Sixel.jl](https://github.com/JuliaIO/Sixel.jl): |
Continuation of #133
Appears to be working fine for me locally and the tests pass locally. I've changed the logic a bit so that we first check
is_sixel_supported, and if that givesfalsethen we checkBase.get_bool_env("REFERENCETESTS_FORCE_SIXEL", false)to see if the user is overriding it for e.g. tests.From @oxinabox's checklist #133 (comment):
Frames also listed
but I think this is unnecessary with my changes since I first check if
is_sixel_supportedand the environment variable is a fallback check.