Skip to content

fix a bug in testing the nesting of the fixed effects - #891

Merged
palday merged 3 commits into
mainfrom
pa/isnested
May 24, 2026
Merged

palday merged 3 commits into
mainfrom
pa/isnested

Conversation

@palday

@palday palday commented May 21, 2026 •

Copy link
Copy Markdown
Member
  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

@palday
palday marked this pull request as ready for review May 21, 2026 22:34
@palday
palday requested a review from dmbates May 21, 2026 22:34
@codecov

codecov Bot commented May 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.65%. Comparing base (dc70a5b) to head (cd02636).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   95.65%   95.65%   -0.01%     
==========================================
  Files          38       38              
  Lines        3728     3726       -2     
==========================================
- Hits         3566     3564       -2     
  Misses        162      162              
Flag Coverage Δ
current 95.32% <100.00%> (-0.01%) ⬇️
minimum 95.59% <100.00%> (+0.05%) ⬆️
nightly 95.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@palday palday changed the title fix a bug in testing the nesting of the fixed effects, fix a bug in testing the nesting of the fixed effects May 22, 2026

@dmbates dmbates left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for following up on this.

@palday
palday merged commit e31ce2a into main May 24, 2026
16 of 21 checks passed
@palday
palday deleted the pa/isnested branch May 24, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants