-
Notifications
You must be signed in to change notification settings - Fork 48
Using VitePress for documentation #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 36 36
Lines 3495 3495
=======================================
Hits 3402 3402
Misses 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think this doc is now good to go! |
is it possible to deploy this only for the dev version to elicit feedback, or deploy an experimental version without taking down the current documentation? |
@palday was that merge commit because there was some merge conflict? The only thing that seems to have changed is the header id, but the final output looks same as the commit before that |
@palday what else needs to be done for this to be merged? |
I updated the preview doc, take a look: https://ajinkya-k.github.io/MixedModels.jl/api |
format = DocumenterVitepress.MarkdownVitepress( | ||
repo = "https://github.com/JuliaStats/MixedModels.jl", | ||
), | ||
clean = true | ||
) | ||
|
||
deploydocs(; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be DocumenterVitepress.deploydocs in DV v0.2
This is a speculative draft PR. I think
VitePress
based docs look much better than the default julia-docs style. While mostly an aesthetic choice, one particular issue with the current docs style is the default fonts chosen byDocumenter.jl
render very poorly for me when using an external monitor with a Mac. So I recreated the documentation for this package usingDocumenterVitepress.jl
and it's deployed for preview at: https://ajinkya-k.github.io/MixedModels.jl/ . I cant setup CI so I manually cobbled together the rendered files on thegh-pages
branch. There are still quite a few kinks to work out but I think it looks great! See for example the Model constructors page for a well rendered page: https://ajinkya-k.github.io/MixedModels.jl/constructorsLet me know what you all think!