bug fix in randindex#99
Open
trappmartin wants to merge 1 commit intoJuliaStats:masterfrom
trappmartin:master
Open
bug fix in randindex#99trappmartin wants to merge 1 commit intoJuliaStats:masterfrom trappmartin:master
trappmartin wants to merge 1 commit intoJuliaStats:masterfrom
trappmartin:master
Conversation
Contributor
|
Hi @trappmartin, thanks for the contribution. Can you give an example of where the current code is incorrect and your code is correct? I'm having trouble creating one. If I have, e.g. c1 = [1]
c2 = [1]then |
Contributor
|
Also, could you also add tests which cover all branches of your changes (once you've verified that they're correct)? |
Author
|
Interesting, I haven't checked this case. c1 = [1, 2, 3]
c2 = [1, 2, 3]which should not be the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RandIndex should be 1. of both assignments are equal. The current code returns 0.