Improve CHOLMOD friendliness #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 83.67% 84.02% +0.35%
==========================================
Files 12 12
Lines 9264 9298 +34
==========================================
+ Hits 7752 7813 +61
+ Misses 1512 1485 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielwe
force-pushed
the
cholmod_friendliness
branch
from
ea03db7 to
5ceee98
Compare
danielwe
force-pushed
the
cholmod_friendliness
branch
from
5ceee98 to
bd3536e
Compare
|
@ViralBShah, thanks for dropping by and marking as draft while I was fixing the tests. CI is all green with 100 % diff coverage now, so this would be ready for review from my side if you want it. |
|
Looks good to me for the most part. It would be nice if @rayegun or @andreasnoack can review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from a discussion on Slack #linear-algebra.
propertynames(::Factor)sparse(F.U)