New package: CorporateFinance v0.1.1 - #167798
Conversation
|
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines are all met! ✅Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. 3. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
40460b6 to
c4abc3b
Compare
|
Thank you for re-submitting your package! As I mentioned on #167234, this still looks premature for registration, and the diff between the commit I looked at there and the one registered here is a UUID change in Two concrete things are broken in the registered commit: The test suite does not run. The reason AutoMerge cannot find your license is that the text of Beyond that, on scope: Related to that: with this kind of very general package name, there might be concerns stemming from the General registry as a shared community resource where "good" package names can become scarce. I also want to make sure that you are aware of the LLM policies for registered packages. The README links to Two smaller things while you are in there: only |
|
Well, Miguel.
Thanks
Understood.
Let's give this more thought. Indeed, WACC and CAPM are fundamental to
corporate finance, but it's true that they don't offer much on their own.
IRR and NPV are part of the ecosystem, though; I included them for the sake
of integration.
I'll hold off for now.
Best regards!
El jue, 10 de sept de 2026, 4:24 p.m., Michael Goerz <
***@***.***> escribió:
… *goerz* left a comment (JuliaRegistries/General#167798)
<#167798 (comment)>
Thank you for re-submitting your package! As I mentioned on #167234
<#167234>, this still
looks premature for registration, and the diff between the commit I looked
at there and the one registered here is a UUID change in Project.toml and
a one-line fix in src/CorporateFinance.jl, so none of that has really
changed.
Two concrete things are broken in the registered commit:
The test suite does not run. test/Project.toml declares CorporateFinance
= "a609d57a-7bd8-4720-b3b3-85eec54e17ef", which is not the UUID of your
package (Project.toml says 22164a04-0d11-4874-9102-ec58c08b414f), so
Pkg.test fails with Unsatisfiable requirements detected for package
CorporateFinance [a609d57a]. That is also why CI has been red for your
last three commits. The package under test should not be listed in
test/Project.toml at all, only the extra test dependencies (here, just
Test). With that line removed, the tests pass.
The reason AutoMerge cannot find your license is that the text of LICENSE
was modified: it reads THE SOFTWARE IS PROVIDED "AS", WITHOUT WARRANTY OF
ANY KIND, where the MIT license says "AS IS". Please copy the license
text verbatim from https://opensource.org/license/MIT.
Beyond that, on scope: npv, irr, payback, and discounting a cash flow to
present value are already available in the ecosystem. FinanceCore.jl
provides irr and present_value, ActuaryUtilities.jl re-exports those and
has breakeven for what you call payback, and NPFinancial.jl covers the
numpy-financial set. Is there a need that these do not fulfill? Could capm,
wacc, beta_regression, and perpetuity be *contributed* to one of the
existing packages instead of registering a new one? As a shared resource
for the Julia community, the General registry strives to reflect a cohesive
ecosystem. Ideally, there are only a small handful of well-maintained
packages for each problem domain.
Related to that: with this kind of very general package name, there might
be concerns stemming from the General registry as a shared community
resource where "good" package names can become scarce. CorporateFinance
claims a whole subdiscipline for eight functions. Would you be open to announcing
this package to the community on Discourse
<https://discourse.julialang.org/c/package-announcements/60> before we
merge this, just to get some feedback? The more general and broad a package
name is, the more "community interest" there is in the quality and
sustainability of the package.
I also want to make sure that you are aware of the LLM policies for
registered packages
<https://github.com/JuliaRegistries/General#is-there-any-policy-regarding-the-use-of-llms-in-registered-packages>.
The README links to https://github.com/JuliaActuary/InterestRates.jl,
which does not exist (InterestRates.jl is at felipenoris/InterestRates.jl),
which is the kind of thing that happens when a README is not written by
hand. Please check the rest of it against your own understanding.
Two smaller things while you are in there: only beta_regression has a
docstring, so ?capm and the others return nothing in the REPL. And you
should install TagBot <https://github.com/JuliaRegistries/TagBot> before
the first tag gets created.
—
Reply to this email directly, view it on GitHub
<#167798?email_source=notifications&email_token=ASM2QOYJFGX45MAXTIREHM35OMS2HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRSGYZDINBUGA2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5626244404>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASM2QO2MRGKTF6VUWJOW6GL5OMS2HAVCNFSNUABFKJSXA33TNF2G64TZHMYTAMJYGA3TKMZRHNEXG43VMU5TKNBRG43TKMJQGQZKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ASM2QO7XFYMWEGWSK6AMCBD5OMS2HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRSGYZDINBUGA2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/ASM2QO5OHG22EZGD6DJPEJ35OMS2HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRSGYZDINBUGA2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
---
yes, I made the 3 corrections you pointed out. Thanks.
El jue, 10 sept 2026 a las 16:32, Miguel ***@***.***>) escribió:
… Well, Miguel.
Thanks
Understood.
Let's give this more thought. Indeed, WACC and CAPM are fundamental to
corporate finance, but it's true that they don't offer much on their own.
IRR and NPV are part of the ecosystem, though; I included them for the sake
of integration.
I'll hold off for now.
Best regards!
El jue, 10 de sept de 2026, 4:24 p.m., Michael Goerz <
***@***.***> escribió:
> *goerz* left a comment (JuliaRegistries/General#167798)
> <#167798 (comment)>
>
> Thank you for re-submitting your package! As I mentioned on #167234
> <#167234>, this still
> looks premature for registration, and the diff between the commit I looked
> at there and the one registered here is a UUID change in Project.toml
> and a one-line fix in src/CorporateFinance.jl, so none of that has
> really changed.
>
> Two concrete things are broken in the registered commit:
>
> The test suite does not run. test/Project.toml declares CorporateFinance
> = "a609d57a-7bd8-4720-b3b3-85eec54e17ef", which is not the UUID of your
> package (Project.toml says 22164a04-0d11-4874-9102-ec58c08b414f), so
> Pkg.test fails with Unsatisfiable requirements detected for package
> CorporateFinance [a609d57a]. That is also why CI has been red for your
> last three commits. The package under test should not be listed in
> test/Project.toml at all, only the extra test dependencies (here, just
> Test). With that line removed, the tests pass.
>
> The reason AutoMerge cannot find your license is that the text of LICENSE
> was modified: it reads THE SOFTWARE IS PROVIDED "AS", WITHOUT WARRANTY
> OF ANY KIND, where the MIT license says "AS IS". Please copy the license
> text verbatim from https://opensource.org/license/MIT.
>
> Beyond that, on scope: npv, irr, payback, and discounting a cash flow to
> present value are already available in the ecosystem. FinanceCore.jl
> provides irr and present_value, ActuaryUtilities.jl re-exports those and
> has breakeven for what you call payback, and NPFinancial.jl covers the
> numpy-financial set. Is there a need that these do not fulfill? Could
> capm, wacc, beta_regression, and perpetuity be *contributed* to one of
> the existing packages instead of registering a new one? As a shared
> resource for the Julia community, the General registry strives to reflect a
> cohesive ecosystem. Ideally, there are only a small handful of
> well-maintained packages for each problem domain.
>
> Related to that: with this kind of very general package name, there might
> be concerns stemming from the General registry as a shared community
> resource where "good" package names can become scarce. CorporateFinance
> claims a whole subdiscipline for eight functions. Would you be open to announcing
> this package to the community on Discourse
> <https://discourse.julialang.org/c/package-announcements/60> before we
> merge this, just to get some feedback? The more general and broad a package
> name is, the more "community interest" there is in the quality and
> sustainability of the package.
>
> I also want to make sure that you are aware of the LLM policies for
> registered packages
> <https://github.com/JuliaRegistries/General#is-there-any-policy-regarding-the-use-of-llms-in-registered-packages>.
> The README links to https://github.com/JuliaActuary/InterestRates.jl,
> which does not exist (InterestRates.jl is at felipenoris/InterestRates.jl),
> which is the kind of thing that happens when a README is not written by
> hand. Please check the rest of it against your own understanding.
>
> Two smaller things while you are in there: only beta_regression has a
> docstring, so ?capm and the others return nothing in the REPL. And you
> should install TagBot <https://github.com/JuliaRegistries/TagBot> before
> the first tag gets created.
>
> —
> Reply to this email directly, view it on GitHub
> <#167798?email_source=notifications&email_token=ASM2QOYJFGX45MAXTIREHM35OMS2HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRSGYZDINBUGA2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5626244404>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ASM2QO2MRGKTF6VUWJOW6GL5OMS2HAVCNFSNUABFKJSXA33TNF2G64TZHMYTAMJYGA3TKMZRHNEXG43VMU5TKNBRG43TKMJQGQZKC5QC>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/ASM2QO7XFYMWEGWSK6AMCBD5OMS2HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRSGYZDINBUGA2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <https://github.com/notifications/mobile/android/ASM2QO5OHG22EZGD6DJPEJ35OMS2HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRSGYZDINBUGA2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
UUID: 22164a04-0d11-4874-9102-ec58c08b414f Repo: https://github.com/ferrerama/CorporateFinance.jl.git Tree: 057257af41267de9370107f14b0389c9439afc1e Registrator tree SHA: 50f504d641745716a5b3eabaf681d3a4937d2ae3
c4abc3b to
eef0239
Compare
|
@goerz I would like to inform you that I am a finance professional (Corporate) with a doctorate in finance. I started a few companies from zero en Central American. Also a evangelical minister. I mean, I would definitely like to expand much more in the future thanks. |
Uh oh!
There was an error while loading. Please reload this page.