Skip to content

New package: RMTool v0.1.0 - #167797

Open
JuliaRegistrator wants to merge 1 commit into
masterfrom
registrator-rmtool-2d0e4950-v0.1.0-3d700e377e
Open

New package: RMTool v0.1.0#167797
JuliaRegistrator wants to merge 1 commit into
masterfrom
registrator-rmtool-2d0e4950-v0.1.0-3d700e377e

Conversation

@JuliaRegistrator

@JuliaRegistrator JuliaRegistrator commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz

goerz commented Sep 11, 2026

Copy link
Copy Markdown
Member

Thank you for submitting your package! The licensing information in the repository is contradictory: the LICENSE file is an MIT license (and that is what the registry will record), while the README and the front page of the documentation both state GPL-2.0-or-later, "as the original toolbox". Since you are the author of the original MATLAB toolbox, you are of course free to relicense the Julia port, but the repository should say the same thing in all three places. Could you settle that before this is merged?

The link from the README to the documentation is also broken: it points to https://rajraomichigan.github.io/RMTool/, but the deployed site is at https://rajraomichigan.github.io/RMTool.jl/. The installation instruction just above it has the same issue (add https://github.com/rajraomichigan/RMTool currently only works because GitHub redirects the old repository name).

One of the README examples is out of date, too: Lmz2MomS(b, 10) for b = wishartpol(1//2) is annotated as [1, 1, 3//2, 5//2, 37//8, ...], but it actually returns [1, 1, 3//2, 11//4, 45//8, ...] (which is what your own test suite asserts). Please make sure that the code and the output shown in the README actually match what the package does. You can add a test that dynamically extracts the examples from the README, writes them to a sandbox folder, and runs them.

Lastly, a recommendation rather than a registration concern: the __precompile__(false) in src/RMTool.jl means that neither RMTool nor any package depending on it can be precompiled, so every session pays the full load cost. The usual way around FLINT handles that cannot be serialized into a precompile cache is to construct the ring inside an __init__() function and assign it to a mutable global, rather than building it at load time.

[noblock]

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Sep 11, 2026
@rajraomichigan

rajraomichigan commented Sep 11, 2026 via email

Copy link
Copy Markdown

@goerz

goerz commented Sep 11, 2026

Copy link
Copy Markdown
Member

Make sure to retrigger the registration from the latest commit, keeping the version number that same, and add [noblock] to you own comment

UUID: 2d0e4950-3c23-4fea-8457-f214aabcb2ed
Repo: https://github.com/rajraomichigan/RMTool.jl.git
Tree: a7095a18a5158b54138eaff9655aafd1e0ff2480

Registrator tree SHA: 50f504d641745716a5b3eabaf681d3a4937d2ae3
@JuliaRegistrator
JuliaRegistrator force-pushed the registrator-rmtool-2d0e4950-v0.1.0-3d700e377e branch from b07e273 to 7a2f7c9 Compare September 11, 2026 20:51
@rajraomichigan

Copy link
Copy Markdown

Fixes pushed, license settled as MIT. [noblock]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants