Dist_graph_create*: Finalize the created communicators - #970
Open
eschnett wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
The tests here fail due to unrelated issues. Merging #982 should help. |
vchuravy
reviewed
Sep 12, 2026
| length(sources), sources, source_weights, | ||
| length(destinations), destinations, destination_weights, | ||
| Info(infokws...), reorder, graph_comm) | ||
| graph_comm != COMM_NULL && finalizer(free, graph_comm) |
Member
There was a problem hiding this comment.
When does graph_comm == COMM_NULL happen? If that is a case we need to worry about I would rather have the check in free since the docs now tells the user to call free.
Contributor
Author
There was a problem hiding this comment.
The standard doesn't mention that it could be COMM_NULL, I think it cannot. This code just follows the usual pattern, and that pattern isn't necessary here.
Should be we be defensive? This way we keep the check here and also add it inside the finalizer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.