Skip to content

Outline error path #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vchuravy wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

Outline error path #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/api/api.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ function Base.show(io::IO, err::FeatureLevelError)
print(io, "FeatureLevelError($(err.function_name)): Minimum MPI version is $(err.min_version)")
end

@noinline function mpi_error(err)
throw(MPIError(err))
end


macro mpichk(expr, min_version=nothing)
if !isnothing(min_version) && expr.args[2].head == :tuple
fn = expr.args[2].args[1].value
Expand All @@ -134,7 +139,13 @@ macro mpichk(expr, min_version=nothing)

expr = macroexpand(@__MODULE__, :(@mpicall($expr)))
# MPI_SUCCESS is defined to be 0
:((errcode = $(esc(expr))) == 0 || throw(MPIError(errcode)))
quote
errcode = $(esc(expr))

@giordano giordano Jul 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be

Suggested change
errcode = $(esc(expr))
local errcode = $(esc(expr))

?

if errcode != 0
$mpi_error(errcode)
end
nothing
end
end


Expand Down
Loading