Skip to content

Revamp prox-grad experiments#48

Merged
kellertuer merged 21 commits into
mainfrom
hajg-ijk/revamp-prox-grad-experiments
Jul 22, 2026
Merged

Revamp prox-grad experiments#48
kellertuer merged 21 commits into
mainfrom
hajg-ijk/revamp-prox-grad-experiments

Conversation

@hajg-ijk

Copy link
Copy Markdown
Member

Reran the experiments for NCRPG to fix the displayed data in the notebooks to be the same as (or at least as close as possible to) the data in the paper.

Added one experiment for CRPG.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.09%. Comparing base (f000798) to head (2a7bff8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          12       12           
  Lines        1355     1355           
=======================================
  Hits         1275     1275           
  Misses         80       80           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kellertuer kellertuer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Paula is now mentioned as an author but you did the PR. Should she maybe contribute a note or change remark so she gets attributed as a contributor to this PR and hence the package as well (on the main page)?

@kellertuer

Copy link
Copy Markdown
Member

Oh and I saw the Docs fail, see
https://github.com/JuliaManifolds/ManoptExamples.jl/actions/runs/29401592344/job/87307159326?pr=48#step:9:833

it seems the images are either numbered differently in the markdown compared to the ones committed or you have maybe forgotten to add an image/figure?

@hajg-ijk

Copy link
Copy Markdown
Member Author

Oh and I saw the Docs fail, see https://github.com/JuliaManifolds/ManoptExamples.jl/actions/runs/29401592344/job/87307159326?pr=48#step:9:833

it seems the images are either numbered differently in the markdown compared to the ones committed or you have maybe forgotten to add an image/figure?

I will check.

@hajg-ijk
hajg-ijk marked this pull request as draft July 20, 2026 12:17
@hajg-ijk
hajg-ijk marked this pull request as ready for review July 21, 2026 12:18
@hajg-ijk
hajg-ijk marked this pull request as draft July 21, 2026 12:52
@hajg-ijk
hajg-ijk marked this pull request as ready for review July 22, 2026 12:17
@kellertuer
kellertuer merged commit aafec16 into main Jul 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants