Skip to content

Don't orphan old julia versions when failing to delete them. #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Don't orphan old julia versions when failing to delete them. #1205

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab3ebbc
don't orphan previous julia version if failed to remove them
ghyatzo May 10, 2025
0089df2
use pattern matching instead
ghyatzo May 10, 2025
ce9e6c1
print something when there is nothing to delete
ghyatzo May 10, 2025
a7b45c4
canonicalize path to delete
ghyatzo May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/operations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,18 +767,29 @@ pub fn garbage_collect_versions(
version: _,
} => true,
}) {
let path_to_delete = paths.juliauphome.join(&detail.path);
let path_to_delete = paths.juliauphome.join(&detail.path).canonicalize()?;
let display = path_to_delete.display();

if std::fs::remove_dir_all(&path_to_delete).is_err() {
eprintln!("WARNING: Failed to delete {}. You can try to delete at a later point by running `juliaup gc`.", display)
match std::fs::remove_dir_all(&path_to_delete) {
Ok(_) => versions_to_uninstall.push(installed_version.clone()),
Err(_) => eprintln!(
"{}: Failed to delete {}. \
Make sure to close any old julia version still running.\n\
You can try to delete at a later point by running `juliaup gc`.",
style("WARNING").yellow().bold(),
display
),
}
versions_to_uninstall.push(installed_version.clone());
}
}

for i in versions_to_uninstall {
config_data.installed_versions.remove(&i);
if versions_to_uninstall.is_empty() {
eprintln!("Nothing to remove.");
} else {
for i in versions_to_uninstall {
eprintln!("{} Julia {}", style("Removed").green().bold(), &i);
config_data.installed_versions.remove(&i);
}
}

if prune_linked {
Expand Down
Loading