Skip to content

Conversation

@topolarity
Copy link
Member

Adapt to major update of JSON.jl: JuliaIO/JSON.jl#374

@topolarity topolarity added ci Continuous integration trimming Issues with trimming functionality or PR's relevant to its performance/functionality labels Oct 3, 2025
@quinnj
Copy link
Member

quinnj commented Oct 3, 2025

Oh hey, didn't realize there was a test on JSON for trimming here! I did run through a few trimming toy executables and made a few tweaks in the new 1.0 release to ensure trim verify worked. I think doing a plain JSON.parse(json) then accessing abi["functions"] might not work though because the return of JSON.parse (untyped) is essentially Union{JSON.Object{String,Any},Vector{Any},String,Int64,Float64,BigInt,BigFloat,Bool,Nothing}, so you might need an assert on the expected type you get out? I'm also a noob at trimming (first time trying it out was yesterday!) so feel free to ignore if I'm spouting nonsense.

@topolarity
Copy link
Member Author

This is not the trimmed executable itself, just a script that verifies the output of the trimmed program / JuliaC 😁

@topolarity topolarity merged commit 7df2a69 into master Oct 3, 2025
3 of 7 checks passed
@topolarity topolarity deleted the ct/fix-trimming branch October 3, 2025 18:46
DilumAluthge added a commit that referenced this pull request Oct 4, 2025
`Libdl`, `Sockets`, and `Test` are non-upgradeable stdlibs that live in
the JuliaLang/julia source tree, so I didn't include compat entries for
them.

`Zstd_jll` is vendored under `test/trimming/Zstd_jll`, and is included
via `[sources]`, so I don't think we need a compat entry for that
either.

A compat entry for `JSON` was added in #59738.

So that just leaves `JLLWrappers`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration trimming Issues with trimming functionality or PR's relevant to its performance/functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants