Skip to content

Conversation

@lazarusA
Copy link
Contributor

this PR moves AWSS3 (AWS) into an extension.

@lazarusA
Copy link
Contributor Author

@meggart @mkitti, here, the extension. CI shows that is ok, however tests locally for MiniIO failed for me. Hopefully all is good.

@coveralls
Copy link

coveralls commented Nov 21, 2025

Pull Request Test Coverage Report for Build 19576861595

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.387%

Totals Coverage Status
Change from base Build 19542891216: 0.03%
Covered Lines: 977
Relevant Lines: 1093

💛 - Coveralls

@mkitti
Copy link
Member

mkitti commented Nov 21, 2025

The MinIO tests are a bit flimsy in my experience as well. Didbm they work better for you previously?

@lazarusA
Copy link
Contributor Author

lazarusA commented Nov 21, 2025

I also updated a test issue that I also fixed in #223

Fletcher32Filter: Error During Test at /home/runner/work/Zarr.jl/Zarr.jl/test/Filters.jl:7
  Got exception outside of a @test
  InexactError: trunc(UInt8, 256)
  Stacktrace:

latest commit fixes this.

@lazarusA
Copy link
Contributor Author

The MinIO tests are a bit flimsy in my experience as well. Didbm they work better for you previously?

I think so, not sure anymore 😄 .

@mkitti mkitti self-requested a review November 24, 2025 16:12
@mkitti
Copy link
Member

mkitti commented Nov 24, 2025

This looks good to merge to me.

@mkitti
Copy link
Member

mkitti commented Nov 24, 2025

Do you want to merge this first and then #223 or the other way around?

@lazarusA
Copy link
Contributor Author

Do you want to merge this first and then #223 or the other way around?

please merge this one first. The merge button still doesn show for me. But its ready !

@nhz2
Copy link
Member

nhz2 commented Nov 24, 2025

Is this a breaking change?
Also curious why an extension vs a subdir package?

This looks good to me as well.

@lazarusA
Copy link
Contributor Author

lazarusA commented Nov 24, 2025

Is this a breaking change? Also curious why an extension vs a subdir package?

This looks good to me as well.

yes, all these, also #223, will be a breaking change. I will add CHANGELOG.md file in a separated PR before tagging the next release.

@mkitti mkitti merged commit 43a180f into JuliaIO:master Nov 24, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants