-
Notifications
You must be signed in to change notification settings - Fork 29
move AWSS3 into extension #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 19576861595Details
💛 - Coveralls |
|
The MinIO tests are a bit flimsy in my experience as well. Didbm they work better for you previously? |
|
I also updated a test issue that I also fixed in #223 latest commit fixes this. |
I think so, not sure anymore 😄 . |
|
This looks good to merge to me. |
|
Do you want to merge this first and then #223 or the other way around? |
please merge this one first. The merge button still doesn show for me. But its ready ! |
|
Is this a breaking change? This looks good to me as well. |
yes, all these, also #223, will be a breaking change. I will add |
this PR moves
AWSS3 (AWS)into an extension.