Fix/in point box for latlon

[debsankha]

WHAT
This fixes #1203, a bug in Base.in(p::Point{🌐}, b::Box{🌐}).

HOW
Defining a new method for geometries on 🌐.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.44%. Comparing base (ec0c5fe) to head (4914f6b).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1207      +/-   ##
==========================================
+ Coverage   88.43%   88.44%   +0.01%     
==========================================
  Files         196      196              
  Lines        6157     6173      +16     
==========================================
+ Hits         5445     5460      +15     
- Misses        712      713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[juliohm]

First round of review attached.

[juliohm]

Thank you @debsankha. Could you please elaborate on the inlonrange method? Appreciate it if you could call viz on every box you added to the tests to make sure they match what you have in mind.

[debsankha]

Thank you @debsankha. Could you please elaborate on the inlonrange method?

Happy to do so. So the function is

function inlonrange(lonₗ, lonₚ, lonᵣ)
  if isnegative(lonₗ) && isnonnegative(lonᵣ)
     lonₚ ≤ lonₗ || (isnonnegative(lonₚ) && lonₚ ≤ lonᵣ)
  else
    lonₗ ≤ lonₚ ≤ lonᵣ
  end
end

The cases are:

• If 0 <= lonₗ <= lonᵣ, the function returns lonₗ ≤ lonₚ ≤ lonᵣ, because the computation is the same as on the real line.
• If 0 >= lonᵣ >= lonₗ, the same applies as above.
• These two cases are handled by the else branch.
• If 0 >= lonₗ and 0 <= lonᵣ, i.e. lonₗ and lonᵣ are on opposite sides of longitude 0 line, there are two cases
  • If lonₚ is on the negative side, inlonrange should be true if and only if it is within the interval [lonₗ, -180], which is equivalent to lonₚ ≤ lonₗ.
  • If lonₚ is on the positive side_, inlonrange should be true if and only if lonₚ ≤ lonᵣ.
  • These two cases are handled by the if branch.

[juliohm]

Thank you @debsankha for the clear explanation and contribution ❤️

[juliohm]

Released a patch with the fix: JuliaRegistries/General#132717