Skip to content

Fix readstring benchmark, add readfloat64. #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix readstring benchmark, add readfloat64. #223

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f07f8
Fix readstring benchmark, add readfloat64.
tkoolen Aug 4, 2018
c5dc1b8
Fix readstring benchmark properly, reuse testbuf again.
tkoolen Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/io/IOBenchmarks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,20 @@ const SUITE = BenchmarkGroup()
# read (#12364) #
#################

function perf_read!(io)
function perf_read!(io, ::Type{T}) where T
seekstart(io)
x = 0
x = zero(T)
while !(eof(io))
x += read(io, UInt8)
x += read(io, T)
end
return x
end

g = addgroup!(SUITE, "read", ["buffer", "stream", "string"])

testbuf = IOBuffer(randstring(RandUtils.SEED, 10^4))

g["read"] = @benchmarkable perf_read!($testbuf)
g["readstring"] = @benchmarkable read($testbuf, String)
g["read"] = @benchmarkable perf_read!(testbuf, UInt8) setup = testbuf = IOBuffer(randstring(RandUtils.SEED, 10^4))
g["readfloat64"] = @benchmarkable perf_read!(testbuf, Float64) setup = testbuf = IOBuffer(randstring(RandUtils.SEED, 10^4))
g["readstring"] = @benchmarkable read(testbuf, String) setup = testbuf = IOBuffer(randstring(RandUtils.SEED, 10^4))

#################################
# serialization (#18633, #7893) #
Expand Down