Allow paths relative to a resource in a subpath.#10
Open
supersaiyen wants to merge 3 commits intoJosiah:masterfrom
Open
Allow paths relative to a resource in a subpath.#10supersaiyen wants to merge 3 commits intoJosiah:masterfrom
supersaiyen wants to merge 3 commits intoJosiah:masterfrom
Conversation
added 3 commits
May 13, 2015 11:18
…ere, like a CSS file including a font in a sub dir, we need to remove the subpath of the file being mapped, since it will not match the resource
Author
|
Longest pull request cycle ever... I've replaced all the string manipulation with the path module. |
|
I think my PR #24 solves this problem using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the contents is on a sub path, and the mapping is relative from there, like a CSS file including a font in a sub dir, we need to remove the subpath of the file being mapped, since it will not match the resource