Skip to content

112 add front end coordinate file parsing functionality#142

Open
joshnorlin wants to merge 50 commits intomainfrom
112-add-front-end-coordinate-file-parsing-functionality
Open

112 add front end coordinate file parsing functionality#142
joshnorlin wants to merge 50 commits intomainfrom
112-add-front-end-coordinate-file-parsing-functionality

Conversation

@joshnorlin
Copy link
Copy Markdown
Collaborator

@joshnorlin joshnorlin commented Apr 9, 2026

This PR accomplishes the following:

  • User can upload a file containing coordinates, and a corresponding file parser grabs the coordinates.
  • The parsing program can handle many popular file formats, such as .csv, .json, .geojson, and .kml, and .shp (zip folder) files.
  • Bad input is prevented via input validation.
  • User can visualize their successfully parsed coordinates on a map and confirm the boundaries.

@joshnorlin joshnorlin requested a review from JosephPBaruch April 9, 2026 01:19
@joshnorlin joshnorlin self-assigned this Apr 9, 2026
@joshnorlin joshnorlin linked an issue Apr 9, 2026 that may be closed by this pull request
Implement front-end coordinate file parsing functionality #112
Open
JosephPBaruch
JosephPBaruch requested changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@JosephPBaruch JosephPBaruch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshnorlin I'll circle back to reviewing once the package issue is resolved.

Comment thread frontend/package.json
Comment thread frontend/tests/charai.spec.ts
@JosephPBaruch JosephPBaruch moved this from Backlog to In review in CharAI Development Apr 9, 2026
@joshnorlin joshnorlin force-pushed the 112-add-front-end-coordinate-file-parsing-functionality branch from c84fce4 to 1e95cb4 Compare April 10, 2026 00:24
JosephPBaruch
JosephPBaruch requested changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@JosephPBaruch JosephPBaruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great! Super impressed on how this came together and it worked super well. Just need a few organization changes and renaming to clear up some confusion.

Comment thread frontend/tests/file-parser.spec.ts Outdated
Comment thread frontend/tests/file-parser.spec.ts
Comment thread frontend/src/pages/LandingPage.tsx Outdated
backgroundColor: theme.palette.mode === "dark" ? "rgba(100, 108, 255, 0.1)" : "rgba(100, 108, 255, 0.08)",
backgroundColor:
theme.palette.mode === "dark"
? "rgba(100, 108, 255, 0.1)"
Copy link
Copy Markdown
Owner

@JosephPBaruch JosephPBaruch Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors like these are used often. Can we define this once and reuse? Perhaps store in the useTheme() hook?

Comment thread frontend/src/features/coordinate_upload/helpers.ts Outdated
JosephPBaruch
JosephPBaruch requested changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@JosephPBaruch JosephPBaruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like You're still working on some stuff so I wont say much. Looking good so far though. I'd say, the validator functions in helper are a bit too tied to the example files. These could be more general like checking a passed in "Total Grid Cells" count

@JosephPBaruch JosephPBaruch moved this from In review to Done in CharAI Development Apr 14, 2026
@joshnorlin joshnorlin force-pushed the 112-add-front-end-coordinate-file-parsing-functionality branch from ff0a74b to 5230ac1 Compare April 16, 2026 22:56
joshnorlin added 18 commits April 19, 2026 17:21
@joshnorlin
feat: add initial drag-n-drop component
2608311
@joshnorlin
style: basic dropzone styling
1844c90
@joshnorlin
feat: added file rejection / error handling
c21e311
@joshnorlin
feat: show accepted files
2f3dcfd
@joshnorlin
feat: display coordinate file upload modal
4f1987a
@joshnorlin
misc: reorganize file directory
8202eda
@joshnorlin
feat: add papaparse dependency
283b106
@joshnorlin
feat: add CSV and KML file parsing capability
dcb636b
@joshnorlin
feat: add wizard-like file configuration ui
bebcb3b
@joshnorlin
feat: refactor components for prop drilling
8418828
@joshnorlin
feat: add kml -> geojson converter and types dependencies
61e06b5
@joshnorlin
feat: add shapefile to geojson converter dependency
ec72279
@joshnorlin
feat: type dependencies
a86a77c
@joshnorlin
feat: add conditional upload screens based on file type
44f44a4
@joshnorlin
feat: add parsing functionality
30b2d19
@joshnorlin
feat(style): integrate theme files
e25cdb6
@joshnorlin
feat(style): change component layout
9010272
@joshnorlin
feat(style): improve spacing and UX
8a37d49
joshnorlin added 28 commits April 19, 2026 17:23
@joshnorlin
fix: resolve ESLint peer dependency issues
29cb66a
@joshnorlin
refactor(test): break down test file
47f56b2
@joshnorlin
feat: improve structure layout
baf98c8
@joshnorlin
fix: removed typing issues
a7041f1
@joshnorlin
fix: last fix I swear
4572292
@joshnorlin
fix(test): improve element selection techniques
8d75e57
@joshnorlin
fix: final fix
2dcbb01
@joshnorlin
fix(test) last last fix, I swear
dd1a832
@joshnorlin
fix: resolve fixture path and __dirname issues in playwright tests
a454dff 
- Fixed __dirname not defined by using import.meta.url with fileURLToPath
- Updated all hard-coded fixture paths to use fixture() helper function
- Added scrolling to MUI Dialog to find coordinate upload button
- Tests now executing successfully (14 passing, 7 failing with error message validation issues)
- Error message validation selectors need refinement for strict mode compliance
@joshnorlin
fix(test): fix helper logic and resolve edge-case issues
b1ec752
@joshnorlin
fix: re-add test package files
5965dfe
@joshnorlin
fix: delete unnecessary files
aea3968
@joshnorlin
fix: change JS module system
7dcab40
@joshnorlin
fix(test): fix test csv's being ignored
1c5c1c2
@joshnorlin
feat(style): minor styling improvements
7630613
@joshnorlin
feat(feedback): refactor test functions for higher reusability
0cfec40
@joshnorlin
feat(test): refactor tests into functions
92c5a99
@joshnorlin
fix: fix shp file parsing
f2c5c30
@joshnorlin
feat: add shp/zip parsing functionality
b48e36d
@joshnorlin
refactor: rename test files for better readability
f7d002e
@joshnorlin
feature: remove unnecessary context state, clear coordinates on submi…
8ee8b17 
…ssion
@joshnorlin
refactor: minor naming / styles changes
7be6914
@joshnorlin
test: add shp file test coverage
0271092
@joshnorlin
style: attempt to modularize styling
260f2ae
@joshnorlin
style: remove use of COLORS object for better modularity
4b09750
@joshnorlin
fix: resolve playwright polling issue
75de579
@joshnorlin
refactor: add fieldInformation parameter to increase testing flexibility
fd37ba7
@joshnorlin
fix: resolve test import coupling error
85935eb
@joshnorlin joshnorlin force-pushed the 112-add-front-end-coordinate-file-parsing-functionality branch from 5230ac1 to 85935eb Compare April 20, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JosephPBaruch JosephPBaruch Awaiting requested review from JosephPBaruch

Requested changes must be addressed to merge this pull request.

Assignees

@joshnorlin joshnorlin

Labels

None yet

Projects

CharAI Development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement front-end coordinate file parsing functionality

2 participants

@joshnorlin @JosephPBaruch