App icon change

[becksen]

update

[Jon-b-m]

Needs some cleaning and refactoring. What does the Test 2.png:s do? Shouldn't it be deleted? Could you please post some screenshots of how the config icon UI Looks like? You have translated the new source string to "AppIcon Wechseln" for every language. You need to create a new config for Icon change instead of using the autotuneConfig. You changed the HomeRootView Icons for Carbs and Settings.

[Jon-b-m]

Please remove the references to Autotune and basal profile etc which you copied from
AutotuneConfig, those are not needed. Please revert the changes you made to iPhone deployment version. Please add a screenshot here for the new app icon config. I would like to see how it looks. I see you removed the option to override the default icon with Config or ConfigOverride. Was this necessary?

[Jon-b-m]

APP_DISPLAY_NAME = FAX AppIcon
This is name of the app in iOS.

[becksen]

Needs some cleaning and refactoring. What does the Test 2.png:s do? Shouldn't it be deleted? Could you please post some screenshots of how the config icon UI Looks like? You have translated the new source string to "AppIcon Wechseln" for every language. You need to create a new config for Icon change instead of using the autotuneConfig. You changed the HomeRootView Icons for Carbs and Settings.

Hi @Jon-b-m, thanks for the remarks. Testimages have been removed. The view has been implemented and reference to autotuneconfig has been removed. HomeRootView icons have been reverted to default.
I've doubts regarding the translation? What is your recommendation to translate the view into the existing languages?

Regards,
becksen.

[becksen]

APP_DISPLAY_NAME = FAX AppIcon This is name of the app in iOS.

Displayname has been reverted to FAX default delivery.

[becksen]

Please remove the references to Autotune and basal profile etc which you copied from AutotuneConfig, those are not needed. Please revert the changes you made to iPhone deployment version. Please add a screenshot here for the new app icon config. I would like to see how it looks. I see you removed the option to override the default icon with Config or ConfigOverride. Was this necessary?

References have been removed.

Not 100% what you mean by
"I see you removed the option to override the default icon with Config or ConfigOverride. Was this necessary?"

BR
becksen

[becksen]

This is not required anymore

[becksen]

Not required

[Jon-b-m]

Not 100% what you mean by "I see you removed the option to override the default icon with Config or ConfigOverride. Was this necessary?"

BR becksen

You hard coded the default App Icons to "AppIcon". Before it was a variable you could change in Config and ConfigOverride. Remove this change, please.

[becksen]

Not 100% what you mean by "I see you removed the option to override the default icon with Config or ConfigOverride. Was this necessary?"
BR becksen

You hard coded the default App Icons to "AppIcon". Before it was a variable you could change in Config and ConfigOverride. Remove this change, please.

Understood. Reverted accordingly.

[Jon-b-m]

Still a lot of test icons. I don't understand the need for those?

[becksen]

Still a lot of test icons. I don't understand the need for those?
I've removed all testicons. Just a number of different icons have been created as alternative. Being able to change the default purple icon, which is also available in xcassets, the other icons have to be available as well in xcassets. Else you wouldn't have alternative to change to. Hope this is clear now. Added two screenshot to show the dependency of the icons in xcassets. If I get other icons I can add them. But this was selection of 5 different colors. If other colors are desired just let me know.

[Jon-b-m]

The grey test Icons "named Test..." are still there. I have the BW and the purple images already, so you shouldn't have to convert and reduce the resolution? And the other icons are not clean and crisp now. Pixels (noise) in wrong colours and blurry.

[Jon-b-m]

Could you make the icons bigger? Too small now in the icon setting view

[becksen]

The grey test Icons "named Test..." are still there. I have the BW and the purple images already, so you shouldn't have to convert and reduce the resolution? And the other icons are not clean and crisp now. Pixels (noise) in wrong colours and blurry.

This is a wrong assumption. Purple and Black is already there, but I haven't touched them. This is from original repo. I assume it is not sufficiently assigned. Means there is just one icon for iOS the others are all mapped to MacOS. My new icons have been properly sized and assigned. Hence they look better when scaled in SwifUI. I can change it for the default icons Purple and Black/White when accepted. Else they will probably look not that nice compared to the new ones.

[Jon-b-m]

I meant in your screenshot. You still have "Test 2" gray icons. in your PR

[Jon-b-m]

Are the Watch Icons changed also with this setting?

[Jon-b-m]

A segmented Picker with Icon images perhaps would look better? And we don't need the Xcode names of icons or the orange borders. Could you please polish the UI a bit?

[becksen]

I meant in your screenshot. You still have "Test 2" gray icons. in your PR

I've cleaned it up. All Icons contain Test or Test2 have been deleted. I don't see it anymore in the fork.

[becksen]

Are the Watch Icons changed also with this setting?

No didn't find any way to do it for watchOS. Only the app icon on iPhone is changed, affected

[Jon-b-m]

Are the Watch Icons changed also with this setting?

No didn't find any way to do it for watchOS. Only the app icon on iPhone is changed, affected

You change the Watch Icons in Xcode here:

[Jon-b-m]

I meant in your screenshot. You still have "Test 2" gray icons. in your PR

I've cleaned it up. All Icons contain Test or Test2 have been deleted. I don't see it anymore in the fork.