Gracefully handle ENOTSUP in ConfigFileManager.chattr0 #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `chattr0` method, which attempts to clear special file attributes (like 'i' for immutable) using `ioctl`, can fail with an `ErrnoException` and the error code `ENOTSUP` (Operation not supported) on certain filesystems or Android environments (e.g., noted on a Android 11 device). When `ioctl` fails with `ENOTSUP`, it means the underlying filesystem does not support the operation of setting/clearing these attributes. In this case, we can safely assume the file/directory is not immutable via this mechanism and treat the operation as a successful non-action. This commit updates `chattr0` to catch `ErrnoException` specifically and return `true` if the error is `OsConstants.ENOTSUP`, preventing unexpected failures in config file management.
Owner
Author
|
@mascherano6-oss, I observed a bug of LSPosed happening on your Android 11 device. Please flash the CI build https://github.com/JingMatrix/LSPosed/actions/runs/21524500540 and upload your logs. |
1 task
|
I installed neozygisk, teesimulator, and lsposed on my Note 3 (Android 11). I've attached the log file. |
Owner
Author
|
@mascherano6-oss Please reboot, and upload your logs here again. No need to upload it elsewhere. |
|
I followed the instructions above. I've attached the log file. |
Owner
Author
|
Confirmed that this commits solved the stated problem. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chattr0method, which attempts to clear special file attributes (like 'i' for immutable) usingioctl, can fail with anErrnoExceptionand the error codeENOTSUP(Operation not supported) on certain filesystems or Android environments (e.g., noted on a Android 11 device).When
ioctlfails withENOTSUP, it means the underlying filesystem does not support the operation of setting/clearing these attributes. In this case, we can safely assume the file/directory is not immutable via this mechanism and treat the operation as a successful non-action.This commit updates
chattr0to catchErrnoExceptionspecifically and returntrueif the error isOsConstants.ENOTSUP, preventing unexpected failures in config file management.