This repository was archived by the owner on Oct 22, 2019. It is now read-only.
Introduce persistent_id for persistent connections #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `predis` extension, the underlying library will re-use connections to same host/port in case of persistent connections. This becomes an issue when the user's application uses the same host of Redis but has different databases, meaning that this library will write to whichever database is previously used by other parts of the code. Using a persistent id forces the library to create a new connection that will not conflict with any other connections being used by the application.
|
This project is dead, but I'm maintaining it under my employer - https://github.com/endclothing/prometheus_client_php. Feel free to submit the PR there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
predisextension, the underlying library will re-useconnections to same host/port in case of persistent connections. This
becomes an issue when the user's application uses the same host of Redis
but has different databases, meaning that this library will write to
whichever database is previously used by other parts of the code.
Using a persistent id forces the library to create a new connection
that will not conflict with any other connections being used by the
application.