Skip to content
This repository was archived by the owner on Mar 26, 2024. It is now read-only.

Add speculative typing latency parameter#77

Merged
Art Pinch (ARTI1208) merged 1 commit into
masterfrom
speculative-typing-latency
Mar 15, 2022
Merged

Add speculative typing latency parameter#77
Art Pinch (ARTI1208) merged 1 commit into
masterfrom
speculative-typing-latency

Conversation

@ARTI1208

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Aug 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #77 (74670d5) into master (c5b949d) will not change coverage.
The diff coverage is n/a.

❗ Current head 74670d5 differs from pull request most recent head 9a34a14. Consider uploading reports for the commit 9a34a14 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #77   +/-   ##
=========================================
  Coverage     25.19%   25.19%           
  Complexity       63       63           
=========================================
  Files           132      132           
  Lines          3893     3893           
  Branches        407      407           
=========================================
  Hits            981      981           
  Misses         2891     2891           
  Partials         21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b949d...9a34a14. Read the comment docs.

@ARTI1208
Art Pinch (ARTI1208) force-pushed the speculative-typing-latency branch 2 times, most recently from 1969e25 to a473835 Compare September 28, 2021 11:52
@ARTI1208
Art Pinch (ARTI1208) changed the base branch from master to speculative-typing-correct-repainting February 27, 2022 14:43
@ARTI1208
Art Pinch (ARTI1208) changed the base branch from speculative-typing-correct-repainting to master February 28, 2022 09:06
@ARTI1208
Art Pinch (ARTI1208) marked this pull request as ready for review February 28, 2022 09:09

@SerVB Sergei Bulgakov (SerVB) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also remind why can it be useful to set it to non-zero? I would also suggest to mention it in the Web Client README in the table of parameters.

@ARTI1208

Art Pinch (ARTI1208) commented Mar 15, 2022

Copy link
Copy Markdown
Contributor Author

It allows simpler debugging speculative typing - you can see speculative symbols longer. Another PR also allows to remove main canvas until speculative symbols are really rendered so only speculative symbols are shown. But PR 76 requires refactoring and some fixes, have no time to do this right now. Also README contains new parameter description

@ARTI1208
Art Pinch (ARTI1208) merged commit 655e5b1 into master Mar 15, 2022
@SerVB
Sergei Bulgakov (SerVB) deleted the speculative-typing-latency branch March 21, 2022 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants