Fix VRAM usage during evaluation - #13
Merged
Mihajlo Linić (MihajloLinic) merged 2 commits intoJul 15, 2026
Merged
Conversation
Collaborator
|
Sorry for not seeing the pull request earlier! I will check it out now |
Collaborator
Great job! We knew there was the memory bug somewhere but didn't have time to go around finding it thank you. I will make sure there are no regressions and merge it
|
Co-authored-by: Junie <junie@jetbrains.com>
Mihajlo Linić (MihajloLinic)
merged commit Jul 15, 2026
ceb54a4
into
JetBrains-Research:main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the unnecessary VRAM usage generated by passing
compute_metricsfor reporting the privacy budget, by overriding thelogmethod instead. It also adds a new privacy parameter calledepsilon_log_modethat can be set to"train","eval","both"(default) or"none", which controls when to report the expended privacy budget. I've updated the documentation and created tests for the feature.Fixes #12