-
Notifications
You must be signed in to change notification settings - Fork 2
Add better error handling #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested on AOT from github workflow, no warnings here, it must be a local generation issue then. |
Could you specify what warning is this and what Graal version you have? If it appears on a newer version of Graal, then it will eventually appear in CI. It's worth opening an issue to resolve this. |
|
Warning text: native-image --version |
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfFromJelly.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfFromJelly.scala
Outdated
Show resolved
Hide resolved
src/test/scala/eu/neverblink/jelly/cli/command/RdfFromJellySpec.scala
Outdated
Show resolved
Hide resolved
|
Tested on AOT and works. Test coverage for methods generally above 80%, most but not every custom exception currently included in test - if needed, more mocks will be added. |
|
Corrected comments, checked AOT/tests, everything still works |
Issue: #25
Adds error handling. Deletes the Fool Around command as well - seems redundant.
Tested on AOT generated locally, but encountered some warnings that were not there when I ran the tests - I'll test it on AOT generated through the github workflow in a minute and let you know.