Fix BASE resolution for formats that support it#222
Merged
Karolina-Bogacka merged 1 commit intomainfrom Sep 14, 2025
Merged
Conversation
Karolina-Bogacka
approved these changes
Sep 14, 2025
Karolina-Bogacka
deleted the
piotr/separate-iri-resolution-and-term-validation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we lumped together IRI resolution with literal validation in the
--validate-termsoption, which is not great. For formats like TTL, JSON-LD and RDF/XML supporting BASE resolution is pretty much mandatory so as not to lose information specified in the file, and we were not doing that by default.This introduces a new option, enabled by default for formats that support BASE, to resolve IRIs properly.
I've also despaghettified the validate-terms option a bit.
This will make parsing of RDF/XML, JSON-LD, and Turtle a bit slower by default, but you can restore previous performance with
--resolve-iris=false.