Print stack trace for all unknown errors#219
Merged
Ostrzyciel merged 1 commit intomainfrom Sep 14, 2025
Merged
Conversation
Karolina-Bogacka
approved these changes
Sep 14, 2025
Collaborator
Karolina-Bogacka
left a comment
Karolina-Bogacka
left a comment
There was a problem hiding this comment.
Ok, I agree with this perspective
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging #217 I noticed that unknown errors are reported by default with a rather unhelpful message:
It would make sense to always print the long stack trace for unknown errors, as otherwise, there is no way to see what happened. Hiding exception details makes sense only for known errors, for which we have helpful user messages.
I changed the ErrorHandler behavior to fix that.