Revert "feat(extension): 多模态视频理解开关 + 抽帧/拼图参数(对齐 web NoteForm)"#354
Open
JefferyHcool wants to merge 1 commit into
Open
Revert "feat(extension): 多模态视频理解开关 + 抽帧/拼图参数(对齐 web NoteForm)"#354JefferyHcool wants to merge 1 commit into
JefferyHcool wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the extension-side support for “视频理解(多模态)” that was previously added to align the extension UI/request payload with the web NoteForm (reverting PR #353).
Changes:
- Removes the “视频理解(多模态)” UI controls (toggle + interval/grid inputs) from the popup and options page.
- Stops sending
video_understanding,video_interval, andgrid_sizein extension/generate_noterequests. - Removes the related settings/request fields from the extension’s TypeScript types and default settings.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| BillNote_extension/src/popup/Popup.vue | Removes popup advanced UI and no longer includes video-understanding fields in the generate request payload. |
| BillNote_extension/src/options/pages/General.vue | Removes the “视频理解(多模态)” section from the options UI. |
| BillNote_extension/src/logic/types.ts | Removes video_understanding / video_interval / grid_size from GenerateRequest and Settings types. |
| BillNote_extension/src/logic/constants.ts | Removes the corresponding defaults from DEFAULT_SETTINGS. |
| BillNote_extension/src/background/main.ts | Stops including video-understanding fields when starting tasks from the background worker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #353