Adjust build#4
Open
BusyJay wants to merge 2 commits into
Open
Conversation
BusyJay
force-pushed
the
adjust-build
branch
from
186d43a to
ab1cc3d
Compare
Owner
|
Thanks for the contribution. I should have time this weekend to review it. I've also turned on issues, so feel free to create a new issue for discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr updates snappy to the latest version and use cmake to build the native library. Using config/make only works on *nix system, and cmake is also recommended by the upstream.
Also can you turn on the issues tab? I want to raise an issue to discuss about whether to build and link to sources by default. But can't find any places to write it down.