fix(release-please): tolerate label-application race#355
Closed
JacobPEvans-personal wants to merge 2 commits into
Closed
fix(release-please): tolerate label-application race#355JacobPEvans-personal wants to merge 2 commits into
JacobPEvans-personal wants to merge 2 commits into
Conversation
…-error The googleapis/release-please-action@v5 step opens the release PR successfully but then immediately tries to apply `autorelease: pending` via GraphQL. The PR's global node ID hasn't propagated yet at that point, so GitHub returns "Could not resolve to a node" — failing the job even though the PR was created correctly. Adding `continue-on-error: true` lets the downstream `Find release PR number` step discover the PR via REST and continue normally. The missing label is cosmetic; release-please re-applies it on the next run. (claude)
continue-on-error masks all release-please failures, not just the transient label-application race. Add a guard step that re-fails the job when the release step errored AND the downstream REST lookup finds no release PR — distinguishing a genuine auth/config/API failure from the harmless race. (claude)
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: trueto the label-application step to tolerate a race condition where the PR is not yet visible when the label workflow firesTest plan