Update merge_duplicate_nodes to return merge mappings #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the return value from a list of deleted node names to a list of tuples containing (deleted_node_name, merged_into_node_name). This provides more context about which nodes were merged together.
Updated existing tests to work with the new tuple return format and added new tests specifically for verifying the merge mapping behavior: - test_merge_mapping_returns_correct_tuple_format - test_merge_mapping_multiple_separate_clusters - test_merge_mapping_chain_collapses_to_first - test_merge_mapping_can_reconstruct_original_references
Collaborator
Author
|
Sorry! Didn't mean to try to merge this into the main branch... Disregard this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the return value from a list of deleted node names to a list of tuples containing (deleted_node_name, merged_into_node_name). This provides more context about which nodes were merged together.