Skip to content

Conversation

@JBenda
Copy link
Owner

@JBenda JBenda commented Nov 20, 2025

As mentioned in #129, a new UE version is out.

I tested the demo project.
Will be at the marketplace soon.

Julian and others added 4 commits November 20, 2025 18:25
refactor: add simple flag to `managad_array` because msvc hicks on implace overwrite of abstract classes
tags for choices where stord as pointer not as offset in array
@JBenda JBenda force-pushed the bump/ue5_7 branch 2 times, most recently from ea7af24 to f351e55 Compare November 28, 2025 09:31
@JBenda
Copy link
Owner Author

JBenda commented Nov 28, 2025

Hey, would you mind checking again?

At least the memory leak is found when reconstructing globals from a snapshot; a temporary string table is constructed.
Which is then also used for reconstructing runners.

This construct was not cleared if a second global was created from the same snapshot.

In short
snap <- state
snap -> g1
snap -> g2
will lead to the strings in G2 pointing to the string table in G1, so when G1 is deleted, they are all dangling.

This was an interesting bug. Thank you very much already for all your help.

reconstructing globals from a snapshot leaves some state behind, when reconstruction again globals from the same snapshot this data need to be cleared first.

refactor: fixes clang compiler warnings
@github-actions
Copy link

Ink Proof Results

These results are obtained by running the Ink-Proof Testing Suite on the compiled binaries in this pull request.

System Results
Linux x64 130/130 passed
MacOSX-ARM DISABLED
MacOSX DISABLED
Windows x64 130/130 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants