Open
Conversation
yakushabb
reviewed
Jan 27, 2026
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <component type="desktop"> | ||
| <id>io.sourceforge.ChessX.desktop</id> | ||
| <id>io.sourceforge.chessx.chessx</id> |
There was a problem hiding this comment.
The current app id is net.sourceforge.Chessx, and you are changing it to net.sourceforge.chessx. Is the flatpak ID park case-sensitive or not?
yakushabb
reviewed
Jan 27, 2026
| <project_license>GPL-2.0-or-later</project_license> | ||
| <name>ChessX</name> | ||
| <developer id="io.sourceforce.chessx"> | ||
| <name>ChessX authors</name> |
There was a problem hiding this comment.
I think using "Jens Nissen" as the author is a better choice.
yakushabb
reviewed
Jan 27, 2026
| @@ -1,9 +1,12 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <component type="desktop"> | |||
| <id>io.sourceforge.ChessX.desktop</id> | |||
There was a problem hiding this comment.
You also need to declare the OLD ID tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings up metainfo.xml and chessx.desktop to newest AppStream standards.
Validation now runs without any errors or comments.