UI FIX: Responsive design#10
Open
Hari-krishna-tech wants to merge 2 commits into
Open
Conversation
Owner
|
Hello @Hari-krishna-tech! Thank you for submitting this PR and try to help make Moogle better. I completely disregarded responsive design when designing the UI. However, after testing it in my Machine I saw a couple of issues. This might've been my fault because currently the npm install
npm run build
docker compose build
docker compose upThis is because I'm wrongly copying the build folder in the Dockerfile. So most likely when you tested the changes it was not compiled properly. Let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR to fix #9
Changes:
before:

After:

PS: I was unable to run the query engine server because I don't have any data in the database. This also prevented me from taking before and after images. Adding an in-memory database for development could rectify this.