[Peras 7] Introduce and propagate feature flags down to NodeKernelArgs #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please note that To provide some confidence about the future integration into |
agustinmista
force-pushed
the
peras/main-pr/introduce-feature-flags
branch
from
d94732b to
8878cb1
Compare
This was referenced Nov 28, 2025
Brings in cardano-base and propagates a set of `CardanoFeatureFlag`s from the top-level `RunNodeArgs` down to the `NodeKernelArgs`. This is currently needed by upcoming PRs that need to conditionally enable certain behavior based on the `PerasFlag` feature flag.
agustinmista
force-pushed
the
peras/main-pr/introduce-feature-flags
branch
from
8878cb1 to
32dbee3
Compare
agustinmista
requested review from
amesgen,
bladyjoker,
dnadales,
fraser-iohk,
geo2a,
jasagredo and
nfrisby
as code owners
jasagredo
approved these changes
Dec 3, 2025
Contributor
jasagredo
left a comment
jasagredo
left a comment
There was a problem hiding this comment.
This looks correct to me.
geo2a
approved these changes
Dec 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
#1780) This PR brings in `cardano-base` and propagates a set of `CardanoFeatureFlag`s from the top-level `RunNodeArgs` down to the `NodeKernelArgs`. This is currently needed by upcoming PRs that need to conditionally enable certain behavior based on the `PerasFlag` feature flag (e.g, spawning voting and object diffusion threads, deciding when a node can consider itself as CaughtUp, etc.).
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
#1780) This PR brings in `cardano-base` and propagates a set of `CardanoFeatureFlag`s from the top-level `RunNodeArgs` down to the `NodeKernelArgs`. This is currently needed by upcoming PRs that need to conditionally enable certain behavior based on the `PerasFlag` feature flag (e.g, spawning voting and object diffusion threads, deciding when a node can consider itself as CaughtUp, etc.).
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in
cardano-baseand propagates a set ofCardanoFeatureFlags from the top-levelRunNodeArgsdown to theNodeKernelArgs.This is currently needed by upcoming PRs that need to conditionally enable certain behavior based on the
PerasFlagfeature flag (e.g, spawning voting and object diffusion threads, deciding when a node can consider itself as CaughtUp, etc.).