-
Notifications
You must be signed in to change notification settings - Fork 29
Add Dijkstra ledger era #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
geo2a
wants to merge
9
commits into
main
Choose a base branch
from
geo2a/issue1544-dijkstra-era
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Dijkstra ledger era #1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17f9373
to
c9dd81e
Compare
10 tasks
dcb8014
to
77f0949
Compare
jasagredo
reviewed
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a drive-by comment
Comment on lines
123
to
125
-- TODO(geo2a): feels weird to introduce a type alias and immediately deprecate it. | ||
-- Do we still need that? | ||
type StandardDijkstra = DijkstraEra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be removed, and all the others too.
20f7234
to
399bf8e
Compare
- update package names - restructure headings - add section on `Ouroboros.Consensus.Cardano.Ledger`
f9064c0
to
f08ebef
Compare
f08ebef
to
d17b50a
Compare
d17b50a
to
1cf12d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544
Needs IntersectMBO/cardano-ledger#5136
Outstanding work:
Test.Cardano.Ledger.Dijkstra.Examples.Consensus
module and exportledgerExamplesDijkstra
. Use this inTest.Consensus.Shelley.Examples
.ToCBOR
andFromCBOR
instances forDijkstraGenesis
. These should be trivial for now.Ouroboros.Consensus.Cardano.CanHardFork
:translateLedgerStateConwayToDijkstraWrapper
translateLedgerTablesConwayToDijkstraWrapper
getDijkstraTranslationContext
translateTxConwayToDijkstraWrapper
translateValidatedTxConwayToDijkstraWrapper