ScheduledMerges: some renaming and new trace messages
#764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and rename its constructors from `MergePolicyTiering` and `MergePolicyLevelling` to `LevelTiering` and `LevelLevelling` respectively. This makes the prototype follow the naming in the real implementation, and it makes it possible to introduce `MergePolicy` as a table-wide configuration option without name clashes.
This follows the naming from the real implementation, and it removes ambiguity with `Op`s from `quickcheck-lockstep`.
These messages helped with troubleshooting #755
jorisdral
force-pushed
the
jdral/proto-misc
branch
from
96c9eab to
0fe8e2c
Compare
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
mheinzel
approved these changes
Jun 26, 2025
| where k = either lookUpVar id evk | ||
| ADelete var evk -> delete tr (lookUpVar var) k >> pure () | ||
| ADelete var evk -> stToIO$ delete tr (lookUpVar var) k >> pure () |
There was a problem hiding this comment.
Suggested change
| ADelete var evk -> stToIO$ delete tr (lookUpVar var) k >> pure () | |
| ADelete var evk -> stToIO $ delete tr (lookUpVar var) k >> pure () |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #763 to prevent merge conflicts
The renamings were some changes I had lying around on an older branch, and the new trace messages I added to troubleshoot #755.