Skip to content

Allow io-classes 1.8.0.1 #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented Jun 3, 2025

This PR allows building lsm-tree with io-classes-1.8.0.1, which is required to start integrating lsm-tree into IntersectMBO/ouroboros-consensus.

Checklist

  • Read our contribution guidelines at CONTRIBUTING.md, and make sure that this PR complies with the guidelines.

Copy link
Collaborator

@jorisdral jorisdral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Are you planning on publishing fs-sim-0.4.0.0 and fs-api-0.4.0.0 on Hackage sometime soon?

@jorisdral
Copy link
Collaborator

I see, input-output-hk/io-sim#217 (comment) has to land first, right?

@geo2a
Copy link
Contributor Author

geo2a commented Jun 3, 2025

I see, input-output-hk/io-sim#217 (comment) has to land first, right?

Yes, otherwise the build fails for GHC 9.2, as caught by the CI

Are you planning on publishing fs-sim-0.4.0.0 and fs-api-0.4.0.0 on Hackage sometime soon?

Yes, I think this is the plan. There's some delay related to the maintainer's email. Hopefully, the release will be unblocked soon.

@jorisdral
Copy link
Collaborator

@geo2a by the way, #753 might be of interest to you

@geo2a geo2a force-pushed the geo2a/io-classes-1.8 branch from eaba46f to 32c4959 Compare June 11, 2025 09:00
- update fs-sim and fs-api
@geo2a geo2a force-pushed the geo2a/io-classes-1.8 branch from 32c4959 to d081bb9 Compare June 11, 2025 09:37
@jorisdral
Copy link
Collaborator

@geo2a if you're happy with the current state of the PR, I'll merge it

@geo2a
Copy link
Contributor Author

geo2a commented Jun 11, 2025

Yes @jorisdral, I think this PR is ready, please feel free to merge. Thanks!

@jorisdral jorisdral added this pull request to the merge queue Jun 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2025
@jorisdral jorisdral added this pull request to the merge queue Jun 11, 2025
Merged via the queue into IntersectMBO:main with commit aa04099 Jun 11, 2025
30 checks passed
@geo2a
Copy link
Contributor Author

geo2a commented Jun 12, 2025

@jorisdral FYI, fs-sim-0.4.0.0 and fs-api-0.4.0.0 are on Hackage:

@jorisdral
Copy link
Collaborator

@jorisdral FYI, fs-sim-0.4.0.0 and fs-api-0.4.0.0 are on Hackage:

* https://hackage.haskell.org/package/fs-api

* https://hackage.haskell.org/package/fs-sim

Thanks very much, I've created #758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants