QLS: statically enable/disable fault injection depending on the SUT #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
changed the title
|
Basic principle sounds fine. |
jorisdral
force-pushed
the
jdral/configurable-faults
branch
from
17a7108 to
58deec5
Compare
|
It's been a while, but I've updated this PR and it should be ready for a review again. The updated diff is now smaller, because there is no renaming of type parameters, and I decided not to include |
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
Faults can only be injected into a mocked HasFS, but not all the SUTs we test use a mocked HasFS. If the SUT does not make use of a mocked HasFS then the result of fault injection will always be InjectFaultAccidentalSuccess. This PR adds some boilerplate for statically enabling/disabling fault injection depending on the SUT. Fault injection is then enabled for the following SUTs: * The "real" implementation in IO using a mocked HasFS * The "real" implementation in IOSim using a mocked HasFS Fault injection is then disabled for the following SUTs: * The reference implementation: it does not use a HasFS * The "real" implementation in IO using the real HasFS: it uses the real file system
jorisdral
force-pushed
the
jdral/configurable-faults
branch
from
58deec5 to
06c7541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faults can only be injected into a mocked HasFS, but not all the SUTs we test
use a mocked HasFS. If the SUT does not make use of a mocked HasFS then the
result of fault injection will always be InjectFaultAccidentalSuccess. This PR
adds some boilerplate for statically enabling/disabling fault injection
depending on the SUT.
Fault injection is then enabled for the following SUTs:
Fault injection is then disabled for the following SUTs:
system