[Enahnce] Resolve config confliction in trainer #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
force-pushed
the
yehc/resolve-trainer-config-confliction
branch
from
c836403 to
22109dc
Compare
1. Resolve ep confliction in `fsdp_cfg` and `model_cfg` 1. Resolve compile confliction in `dataloader_cfg`, `model_cfg` and `fsdp_cfg`
HAOCHENYE
force-pushed
the
yehc/resolve-trainer-config-confliction
branch
from
22109dc to
4e16ead
Compare
HIT-cwh
approved these changes
Dec 11, 2025
HAOCHENYE
force-pushed
the
yehc/resolve-trainer-config-confliction
branch
4 times, most recently
from
765c804 to
c3b6de0
Compare
HAOCHENYE
force-pushed
the
yehc/resolve-trainer-config-confliction
branch
from
c3b6de0 to
3369deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsdp_cfgandmodel_cfgdataloader_cfg,model_cfgandfsdp_cfg