Fix INVENTORYSTATE example to use valid values#53
Open
cabaret-pro wants to merge 1 commit intoInteractiveAdvertisingBureau:masterfrom
Open
Fix INVENTORYSTATE example to use valid values#53cabaret-pro wants to merge 1 commit intoInteractiveAdvertisingBureau:masterfrom
cabaret-pro wants to merge 1 commit intoInteractiveAdvertisingBureau:masterfrom
Conversation
The example for INVENTORYSTATE incorrectly included "fullscreen" which is not a valid INVENTORYSTATE value. "fullscreen" is a PLAYERSTATE value. Changed the example from "autoplayed,fullscreen" to "autoplayed,skippable" using valid INVENTORYSTATE values as defined in INVENTORYSTATE_values. Fixes InteractiveAdvertisingBureau#27 Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Updated to reflect correct value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoplayed,fullscreentoautoplayed,skippableusing valid INVENTORYSTATE valuesDetails
The
INVENTORYSTATE_valuesin the macros data defines valid values as:skippableautoplayedmautoplayedoptinThe previous example
autoplayed,fullscreenwas incorrect becausefullscreenbelongs toPLAYERSTATE_values, notINVENTORYSTATE_values.Fixes #27
Test plan
Made with Cursor